Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.2.1 JSON_ERROR_NONE PHP 5.2 incompaibility #266

Closed
mikejolley opened this issue Mar 25, 2019 · 1 comment
Closed

2.2.1 JSON_ERROR_NONE PHP 5.2 incompaibility #266

mikejolley opened this issue Mar 25, 2019 · 1 comment
Assignees
@JPry

Comments

@mikejolley
Copy link
Member

mikejolley commented Mar 25, 2019 •
edited
Loading

Introduced in 2.2.1, this code is not compatible with PHP 5.2:

a6dd57d

Reported here:
woocommerce/woocommerce#23121

@JPry
@mikejolley mikejolley mentioned this issue Mar 25, 2019
Closed
@DavidAnderson684
Copy link

N.B. It's not just the constant, but also the method json_last_error() which doesn't exist before 5.3.

@JPry JPry mentioned this issue Mar 26, 2019
Merged
@JPry JPry added the hasPR label Mar 26, 2019
@JPry JPry self-assigned this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPry JPry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikejolley @JPry @DavidAnderson684