Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code sniffing #331

Closed
rrennick opened this issue Jul 17, 2019 · 2 comments
Closed

Add code sniffing #331

rrennick opened this issue Jul 17, 2019 · 2 comments
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Milestone

Comments

@rrennick
Copy link
Contributor

Follow up from #323 (comment)

The question on that is which set of standards should it follow? It definitely doesn't follow WP standards yet.

WP coding standards for newer versions of PHP

The WP standards all seemed fine for me except prohibiting the use of short array syntax. With appropriate spacing, I find the short syntax easier to read (partly because it is formatted similar to JSON).

Since that is the first pass at standards for the newer language features, it may change in the future based on community reaction so we shouldn't feel bound to that.

@rrennick rrennick added question type: task The issue is an internally driven task (e.g. from another A8c team). labels Jul 17, 2019
@thenbrent thenbrent added this to the 3.1.0 milestone Aug 7, 2019
@claudiosanches
Copy link
Contributor

I started a Pull Request using the dev tools that we use on WooCommerce, I hope this may help you all #383

@barryhughes
Copy link
Member

With the work done in PR #383 seems like this can be closed (and we can follow-up in further issues if we want to take it further, such as integrating with GH Actions or similar)—feel free to re-open if I'm mistaken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task The issue is an internally driven task (e.g. from another A8c team).
Projects
None yet
Development

No branches or pull requests

5 participants