Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace single requests with Batch requests #2592

Closed
ibndawood opened this issue Jul 26, 2023 · 1 comment
Closed

Replace single requests with Batch requests #2592

ibndawood opened this issue Jul 26, 2023 · 1 comment
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@ibndawood
Copy link
Contributor

The plugin uses a single request for publishing and updating simple products and uses batch requests for variable products. The parameters are different for single requests and batch requests appear different, causing a lot of redundant code. By replacing the single request with a batch request for simple products, we can get rid of redundant code.
@ibndawood ibndawood added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Jul 26, 2023
@ibndawood ibndawood changed the title Replace single request with Batch requests Replace single requests with Batch requests Jul 26, 2023
@rawdreeg
Copy link
Contributor

I belied this was resolved by #2672. I will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibndawood @rawdreeg