Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of get_title vs. get_name on product objects #2774

Closed
Dekadinious opened this issue Jul 27, 2024 · 2 comments · Fixed by #2781
Closed

Inconsistent use of get_title vs. get_name on product objects #2774

Dekadinious opened this issue Jul 27, 2024 · 2 comments · Fixed by #2781
Assignees
Labels
type: bug The issue is a confirmed bug.

Comments

@Dekadinious
Copy link

You sometimes use $product->get_title() for content_name and sometimes use $product->get_name().

This creates inconsistencies between events and the catalog.

@brezocordero
Copy link
Contributor

brezocordero commented Aug 2, 2024

Thanks for the report @Dekadinious

Adding some notes:
$product->get_title() is used on this event, the other events use $product->get_name(). Should be consistent.

@brezocordero brezocordero added the type: bug The issue is a confirmed bug. label Aug 2, 2024
@rawdreeg
Copy link
Contributor

rawdreeg commented Aug 8, 2024

Thanks, @brezocordero, for looking into this. I will add a quick PR to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants