Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pasting the phone verification code. #1001

Closed
tomalec opened this issue Sep 9, 2021 · 4 comments
Closed

Support pasting the phone verification code. #1001

tomalec opened this issue Sep 9, 2021 · 4 comments
Assignees
@puntope
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@tomalec
Copy link
Member

tomalec commented Sep 9, 2021

User story

As a merchant, I'd like to easily copy the verification code from SMS and past it into GLA input fields.
(Personally, I find such flow useful when using my mobile)

Currently, when I paste, only the first character is put into the first number field.

paste

Technical

Figma link

Acceptance criteria

Unknowns

Out of bounds/rabbit holes

Event tracking
@tomalec tomalec added type: enhancement The issue is a request for an enhancement. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. labels Sep 9, 2021
@nima-karimi nima-karimi added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Nov 17, 2021
@puntope
Copy link
Contributor

puntope commented Nov 17, 2021

@tomalec

I'm working on this issue.

Possible to have step by step guide in order to reproduce the issue?

Thanks!

@puntope
Copy link
Contributor

puntope commented Nov 17, 2021

Possible to have step by step guide in order to reproduce the issue?

  1. Setup merchant page
  2. Section 4 (Confirmation)
  3. Send Verification code

Screenshot 2021-11-17 at 13 12 38

@tomalec
Copy link
Member Author

tomalec commented Nov 17, 2021

Possible to have step by step guide in order to reproduce the issue?

Sorry, that I didn't add detailed steps in advance. I created it in the times when the flows and URLs where this component was available were quite volatile. And I consider this a feature request for a single component, regardless of its placement.

Yep, that's one way to get this view:

Setup

  1. Start the setup /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc
  2. Complete the setup through 4th step /wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-mc&google-mc=connected
  3. Provide a real phone number
    go to phoneverification

Settings

The other is, once you're set up

  1. Go to settings
  2. Click "Edit" in phone number card, and go to /wp-admin/admin.php?page=wc-admin&subpath=%2Fedit-phone-number&path=%2Fgoogle%2Fsettings

@puntope puntope mentioned this issue Nov 23, 2021
Closed
@mikkamp
Copy link
Contributor

mikkamp commented Nov 14, 2024

Phone number verification is being removed in #2653 so I'm closing this issue as no longer applicable.

@mikkamp mikkamp closed this as completed Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@puntope puntope

Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. priority: low The issue/PR is low priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support paste verification woocommerce/google-listings-and-ads
4 participants
@tomalec @puntope @mikkamp @nima-karimi