Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Ads value prop in Paid Campaign performance card #2538

Closed
6 tasks
Tracked by #2460
joemcgill opened this issue Aug 16, 2024 · 4 comments · Fixed by #2650
Closed
6 tasks
Tracked by #2460

Show Ads value prop in Paid Campaign performance card #2538

joemcgill opened this issue Aug 16, 2024 · 4 comments · Fixed by #2650
Assignees

Comments

@joemcgill
Copy link
Collaborator

joemcgill commented Aug 16, 2024

Part of #2460

In order to better explain why someone should set up their first PMax campaign, we'll update the Paid Campaign card in the dashboard to show a similar value prop as the one shown during onboarding.

image

Acceptance Criteria

  • Display the Paid Ads features value prop card when:
    • the connected Ads account has not completed the setup flow (see discussion), or
    • if the Ads account does not have any existing campaigns
  • If the account is eligible to see the $500 ads credit (see: Clarify requirements for displaying Free Ads Credits #2599), include the banner.
  • Clicking the Create Campaign button should open the same Create Campaign flow as the current Paid Campaign card.
  • Once a campaign has been created, the Paid Campaign card should show performance metrics from the current card.

Implementation Brief

  • Create js/src/dashboard/summary-section/paid-features.js which will house the PaidFeatures component.
    • Render the component as per the ticket description.
    • The paid features are also found in js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-features-section.js
      • Extract the features into a common component which can be used for both, PaidAdsFeaturesSection and PaidFeatures.
    • For the $500 as credit implementation, implementation details can be taken from js/src/setup-mc/setup-stepper/setup-paid-ads/paid-ads-features-section.js
    • Button for "Create campaign" should possibly reuse js/src/components/paid-ads/add-paid-campaign-button.js.
      • Necessary updates should be make to the componen so that it can be used across different components.
      • Possibly mode the component to js/src/component
  • Using js/src/dashboard/summary-section/index.js,
    • Add PaidFeatures to SummarySection if
      • adsSetupComplete is true
      • and there are no campaign.
        • To check whether there are no campaigns, use the useAdsCampaigns
  • We will deprecate the useFreeAdCredit() while implementing this, see Clarify requirements for displaying Free Ads Credits #2599. Instead of any places where that hook is currently in use should be updated so that the Ads Credit banner is always shown when there are no existing campaigns.

Test Coverage

  • Appropriate E2E tests should be added to test for PaidFeatures to be displayed/hidden.

Definition Questions

  • What is the condition to replace the useFreeAdCredit hook?
@joemcgill joemcgill self-assigned this Aug 16, 2024
@joemcgill joemcgill added the needs design The issue requires design input/work from a designer. label Aug 16, 2024
@joemcgill joemcgill changed the title Show value prop in Paid Campaign performance card [⚠ Needs Design] Show Ads value prop in Paid Campaign performance card Aug 16, 2024
@joemcgill joemcgill removed the needs design The issue requires design input/work from a designer. label Oct 1, 2024
@joemcgill
Copy link
Collaborator Author

As part of this issue, we'll deprecate and remove the useFreeAdCredit hook based on the discussion related to #2599.

@asvinb
Copy link
Collaborator

asvinb commented Oct 3, 2024

@joemcgill I've added the IB. Can you kindly take a look please? Left a question about the useFreeAdCredit.

@joemcgill
Copy link
Collaborator Author

@asvinb I've tried to clarify the part about deprecating the useFreeAdCredit hook in the IB. I think everything else looks good.

@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Oct 30, 2024
@kt-12 kt-12 assigned eason9487 and kt-12 and unassigned kt-12 and eason9487 Nov 1, 2024
@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Nov 1, 2024
@kt-12 kt-12 assigned eason9487 and unassigned kt-12 Nov 5, 2024
@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Nov 6, 2024
@joemcgill joemcgill assigned eason9487 and unassigned kt-12 Nov 7, 2024
@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Nov 7, 2024
@kt-12 kt-12 assigned eason9487 and unassigned kt-12 Nov 7, 2024
@eason9487 eason9487 removed their assignment Nov 7, 2024
@mikkamp
Copy link
Contributor

mikkamp commented Dec 2, 2024

Closing this as completed since it was part of the 2.9 release.

@mikkamp mikkamp closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants