-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Create new MC account when there are existing accounts in Google Accounts Card #2604
Comments
@joemcgill Can you kindly check the proposed IB please? |
This looks good to me.
We could split this off to a separate ticket or make it a part of #2597. Seems like we should have the UI and logic for that in place before picking this up. @asvinb and @eason9487, would be curious to get your thoughts on this ☝ |
The first suggestion is similar to #2603 (comment). The second one is if this consolidated component will be used in this plugin's Settings or Ads-onboarding page as well, it needs to take care of they don't offer the functionality to disconnect Merchant account. |
@joemcgill Can you confirm that for now the component will be used for the onboarding flow only? |
@asvinb this component will only be used in the onboarding flow. The original |
Similar to #2603, we'll need to update this link once the component is updated so that it reads "Or, connect to a different Google Merchant Center account". See how this looks in the current single account component: When that link is clicked we should fire off the DELETE request to the |
Thanks @joemcgill . IB has been updated! |
Thanks @asvinb. The updates look good to me. @eason9487 does this satisfy your concerns? |
Thanks for the update! Looks good. |
@eason9487 Tackled as part of the PR for #2597 |
Closing this as completed since it was part of the 2.9 release. |
Caution
Depends on #2597
Part of #2509
While connecting the store to Merchant Center, a merchant may want to create a new account, even if they already have existing accounts associated with their Google account.
To support this, we will add a link below the account selector to kick off account creation.
Clicking this link should show the same "Are you sure" modal that is shown today, which lets them initiate account creation or cancel.
Once they confirm they want a new account, the account selector will replaced with a message that reads:
And the Connect button will be replaced by a loading spinner with the word "Creating..."
If the merchant needs to reclaim their URL, we'll display the reclaim UI in the card as shown:
Once the new account is created and reclaimed, the card will show the new account as connected
Background
In the current
GoogleMCAccountCard
, when there are already MC accounts associated with the Google account, we show a link below the account selector that allows them to create a new account instead of selecting an existing one.Clicking this link shows a modal to confirm they want to create an account.
Once they've confirmed they want a new account and have accepted terms and conditions (not applicable, since they now accept terms and conditions when connecting their Google account), we show this UI while the account is being connected.
After the new account is created, the user is shown the UI to reclaim their URL if applicable:
Acceptance Criteria
Implementation Brief
ConnectMC
component created in Onboarding: Connect to existing MC account in Google Accounts Card #2597,WarningModal
fromjs/src/components/google-mc-account-card/warning-modal/index.js
should be rendered, prompting the user's confirmation.handleCreateAccount
function from theuseCreateMCAccount
hook.js/src/components/google-mc-account-card/create-account.js
ReclaimUrlCard
if the URL needs to be reclaimed.js/src/components/google-mc-account-card/connect-mc/index.js
as inspiration.handleConnectMC
function via theuseConnectMCAccount
hook.js/src/components/google-mc-account-card/connect-mc/index.js
on how to pass the new Google MC ID touseConnectMCAccount
useCreateMCAccount
hook.handleSwitch
injs/src/components/google-mc-account-card/connected-google-mc-account-card.js
js/src/components/google-mc-account-card/connected-google-mc-account-card.js
and current component.Test Coverage
Definition Questions
The text was updated successfully, but these errors were encountered: