Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Ensure woocommerceanalytics_product_purchase fires for stores that use blocks #2032

Closed
haszari opened this issue Mar 26, 2020 · 4 comments
Closed
Assignees
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.

Comments

@haszari
Copy link
Member

haszari commented Mar 26, 2020

We'll use the woocommerceanalytics events (from Jetpack) for measuring conversion rate of the new block-based cart & checkout, and comparing with existing (shortcode) flow.

We need the purchase event to fire correctly for stores using blocks.

See also #2031 #2030

@haszari
Copy link
Member Author

haszari commented Mar 29, 2020

This event is sent from a callback on woocommerce_thankyou hook.

This hook is fired from the Woo core checkout thankyou template. I think this should all work the same for orders submitted from checkout block (vs traditional shortcode).

@mikejolley Can you confirm my suspicions - normal Woo core order handling will take place after order is submitted via checkout block?

We'll need to test this to be sure (alongside more comprehensive testing of all the events), but for now I'm assuming this event will work correctly. Leaving this issue open until we can test this, when checkout block is hooked up to submitting real order.

@haszari haszari added the status: blocked The issue is blocked from progressing, waiting for another piece of work to be done. label Mar 29, 2020
@mikejolley
Copy link
Member

I mean, it will work initially, but I'm not sure if we'll use that thanks page forever.

@haszari
Copy link
Member Author

haszari commented Mar 30, 2020

I mean, it will work initially, but I'm not sure if we'll use that thanks page forever.

@mikejolley Agreed, this doesn't feel super robust. Will leave this issue open until we confirm this is firing for block-based checkouts.

Long term this is essentially a WooCommerce Analytics maintenance issue – the events code needs to be maintained as woo & blocks develop over time.

@nerrad nerrad modified the milestones: Future Release, 2.6.0 Apr 17, 2020
@nerrad nerrad removed this from the 2.6.0 milestone May 1, 2020
@nerrad nerrad added block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. labels Jun 7, 2020
@haszari
Copy link
Member Author

haszari commented Jul 29, 2020

Tested this on an ephemeral site (jetpack connected etc) and confirmed the event is firing for cart + checkout block purchase flow.

I don't think we need to keep this issue open, and there's no action we need to take now.

If we need to do more work in this area we can open new issues as needed. For example:

  • If we move away from the thankyou template (no current plans to do so), we'll need to add new code for firing purchase event.
  • Similar for anything that affects the purchase funnel, e.g. if we add a new add-to-cart mechanism in single product block.
  • When we are preparing for launch on eCommerce plan, we may need to retest this to confirm everything's still firing, or adapt or add new events as needed to measure impact of blocks.

With that in mind, I'm closing this :)

cc @nerrad @Aljullu - feel free to open a new issue for any specific follow up for this sprint/cycle.

@haszari haszari closed this as completed Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: cart Issues related to the cart block. block: checkout Issues related to the checkout block. status: blocked The issue is blocked from progressing, waiting for another piece of work to be done.
Projects
None yet
Development

No branches or pull requests

3 participants