Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Templates can't be saved in WP 5.9 beta 3 with Gutenberg disabled #5402

Closed
Aljullu opened this issue Dec 16, 2021 · 0 comments · Fixed by #5408
Closed

Templates can't be saved in WP 5.9 beta 3 with Gutenberg disabled #5402

Aljullu opened this issue Dec 16, 2021 · 0 comments · Fixed by #5408
Assignees
@Aljullu
Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug.
Milestone
6.5.1

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Dec 16, 2021 •
edited
Loading

To reproduce

  1. With WP 5.9 beta 3 and Gutenberg disabled, go to Appearance > Editor.
  2. Edit one of the WooCommerce templates and try to save it.
  3. Notice you get a 404 error: No templates exist with that id..

The problem seems to be that we check for the existence of gutenberg_get_block_template(), however that function was renamed to get_block_template() when included to WP core, so if Gutenberg is not enabled that function always returns early.
@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. status: blocker Used on issues or pulls that block work from being released. focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor labels Dec 16, 2021
@Aljullu Aljullu added this to the 6.5.1 milestone Dec 16, 2021
@Aljullu Aljullu self-assigned this Dec 17, 2021
@Aljullu Aljullu mentioned this issue Dec 17, 2021
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Aljullu Aljullu

Labels
focus: FSE Work related to prepare WooCommerce for FSE. focus: template Related to API powering block template functionality in the Site Editor status: blocker Used on issues or pulls that block work from being released. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Milestone
6.5.1
Development

Successfully merging a pull request may close this issue.

Fix saving WooCommerce templates in WP 5.9 beta 3 woocommerce/woocommerce-blocks
1 participant
@Aljullu