Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

TT3 theme: some buttons are not legible with some style variations #7466

Closed
Aljullu opened this issue Oct 24, 2022 · 2 comments
Closed

TT3 theme: some buttons are not legible with some style variations #7466

Aljullu opened this issue Oct 24, 2022 · 2 comments
Assignees
Labels
block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. block-type: product-grid Issues related to/affecting all product-grid type blocks. type: bug The issue/PR concerns a confirmed bug.

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Oct 24, 2022

Describe the bug

WC Blocks buttons are not legible with specific Twenty Twenty Three style variations. Originally reported by @peterfabian.

To reproduce

  1. Download and activate TT3.
  2. Add the Products by Category block and select clothing.
  3. Visit the page in the frontend.
  4. Test all TT3 style variations (Appearance > Site Editor > Styles > Browse Styles).
  5. Notice with some of them buttons text is not visible.

We should test all other blocks to verify which ones are affected.

Expected behavior

Buttons should be legible.

Screenshots

imatge

Proposed solution

I think that if we add the Elements API class (wp-element-button) to all buttons, they will display correctly. That class can be retrieved (in WP 6.1) with WP_Theme_JSON_Gutenberg::get_element_class_name( 'button' ).

@Aljullu Aljullu added type: bug The issue/PR concerns a confirmed bug. block-type: product-grid Issues related to/affecting all product-grid type blocks. block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. theme: Twenty Twenty-Three labels Oct 24, 2022
@Aljullu
Copy link
Contributor Author

Aljullu commented Oct 25, 2022

Related issue: #7388.

They might even be the same issue or be two different issues that could be fixed with the same fix, but I logged it separately just in case.

@gigitux
Copy link
Contributor

gigitux commented Oct 31, 2022

#7388 fixes this issue.

@gigitux gigitux closed this as completed Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block: featured category Issues related to the Featured Category block, block: featured product Issues related to the Featured Product block. block-type: product-grid Issues related to/affecting all product-grid type blocks. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

No branches or pull requests

2 participants