Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Query [3]: [Tests] Unit test that queries are merged correctly by the ProductQuery class #7627

Closed
Tracked by #42616
sunyatasattva opened this issue Nov 8, 2022 · 0 comments · Fixed by #7747
Closed
Tracked by #42616

Product Query [3]: [Tests] Unit test that queries are merged correctly by the ProductQuery class #7627

sunyatasattva opened this issue Nov 8, 2022 · 0 comments · Fixed by #7747
Labels
block-type: product-query Issues related to/affecting all product-query variations.

Comments

@sunyatasattva
Copy link
Contributor

The ProductQuery class is responsible for taking all the settings and making the correct query. As we add settings and ways to mix and match them, the logic doing the merging becomes more complex and brittle. We should have at least good coverage of this part of the logic with unit tests.

Eventually, with woocommerce/woocommerce#42534 we aim for full unit test coverage of the class.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
block-type: product-query Issues related to/affecting all product-query variations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Product Query unit tests woocommerce/woocommerce-blocks
1 participant
@sunyatasattva