Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Categories List causing one pixel white line at the end of the page in some themes #837

Closed
Aljullu opened this issue Aug 12, 2019 · 2 comments · Fixed by #849
Closed
Assignees
Labels
type: bug The issue/PR concerns a confirmed bug.
Milestone

Comments

@Aljullu
Copy link
Contributor

Aljullu commented Aug 12, 2019

Reported in the support forum:
https://wordpress.org/support/topic/one-pixel-horizontal-line-at-bottom-of-site-pages/

When using the Eikra theme, a white line appears at the bottom of the page caused by the Product Categories List block button.

The specific line causing the issue:
https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/master/assets/js/blocks/product-categories/style.scss#L41

I assume it comes from:
https://github.com/WordPress/gutenberg/blob/master/packages/components/src/button/style.scss#L255

We could check if this line is really necessary in the Product Categories List considering it doesn't have text inside the button.

@Aljullu Aljullu added the type: bug The issue/PR concerns a confirmed bug. label Aug 12, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label type: bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@mikejolley mikejolley self-assigned this Aug 13, 2019
@mikejolley mikejolley added this to the 2.3.1 milestone Aug 13, 2019
@mikejolley
Copy link
Member

Fixed in #849

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants