Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Improve editor placeholder for the Order received template #9292

Closed
Tracked by #9288
wavvves opened this issue Apr 28, 2023 · 7 comments · Fixed by #9602
Closed
Tracked by #9288

Improve editor placeholder for the Order received template #9292

wavvves opened this issue Apr 28, 2023 · 7 comments · Fixed by #9602
Assignees
Labels
focus: FSE Work related to prepare WooCommerce for FSE. needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.

Comments

@wavvves
Copy link
Contributor

wavvves commented Apr 28, 2023

Part of Epic: Cart/Checkout/Order Received Templates #9288

p1682578579143099-slack-C04NWH6NDHA

Currently, as part of the POC for the Order Received, we render a generic placeholder for the Order Received block which will not be editable at this point, as blockifying it will be the result of the next phase of work with templates.

Current placeholder:

image

(Note: the placeholder title is wrongly declared as "Classic Product template", this will be updated soon)

This issue serves to evaluate the need to have some parity between what we see in the editor and frontend vs using a more basic representation taking into account that this will be upgraded into a full editable component.

@wavvves wavvves added type: enhancement The issue is a request for an enhancement. focus: FSE Work related to prepare WooCommerce for FSE. labels Apr 28, 2023
@wavvves wavvves added the needs: design The issue requires design input/work from a designer. label May 18, 2023
@mikejolley
Copy link
Member

Since this task is blocked by design it should probably not be in the current sprint, unless we are coming up with a temporary placeholder due to the intention to blockify the page in the near future cc @ralucaStan

@ralucaStan
Copy link
Contributor

@shaunandrews how soon can we discuss on a proposal for the placeholder?

@mikejolley @wavvves what can we display now? Can we share this to kickstart the discussion?

@mikejolley
Copy link
Member

@ralucaStan I think there are some existing blocks we could base a solution of. For example the legacy products placeholder:

Screenshot 2023-05-19 at 10 38 00

@ralucaStan
Copy link
Contributor

Thank you @mikejolley !

@shaunandrews can't we proceed with this pattern, used on other templates, instead of creating a default placeholder just for the Order received template? This has multiple benefits:

  • it aligns with the other templates used and creates consistency
  • it's not work we'll need to redo once we blockify the content for this template later in the year
  • we can use the time invested in researching the implementation in making progress on impactful areas if this project

If the current placeholder (shared above) is something that you think should be improved @shaunandrews we can do this for all templates outside of this project.

cc @pmcpinto

@kellychoffman
Copy link

[description to be submitted]

What exactly is the issue/scope/task? Ideally, its laid out in the first comment so design is clear on what to do.

@shaunandrews
Copy link

We could use a generic UI skeleton, or forgo that visual representation in favor of a much smaller footprint using only text:

CleanShot 2023-05-22 at 11 42 20@2x

However, my instinct is that this placeholder should look like an Order Received template, and not some UI abstraction. Maybe the resting state of the block shows (generally) how the default WooCommerce thankyou.php template most commonly appears. Extra points if we can bring in typography and color from Global Styles. Selecting the block would blur this example and display a message explaining the block and its limitations.

CleanShot 2023-05-22 at 11 41 22@2x

@wavvves
Copy link
Contributor Author

wavvves commented May 23, 2023

CleanShot 2023-05-22 at 11 41 22@2x

@mikejolley do you think it's possible to mock an order object, load up thankyou.php HTML with global styles applied, and implement this idea by @shaunandrews ? 🤔

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
focus: FSE Work related to prepare WooCommerce for FSE. needs: design The issue requires design input/work from a designer. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants