Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Product Image block: image is missing loading, srcset, and sizes attributes #9979

Closed
dinhtungdu opened this issue Jun 23, 2023 · 0 comments · Fixed by #9984
Closed

Product Image block: image is missing loading, srcset, and sizes attributes #9979

dinhtungdu opened this issue Jun 23, 2023 · 0 comments · Fixed by #9984
Assignees
Labels
block-type: product-query Issues related to/affecting all product-query variations. type: bug The issue/PR concerns a confirmed bug.

Comments

@dinhtungdu
Copy link
Member

Describe the bug

The image of the Product Image block is missing loading and responsive attributes, which causes some performance issues:

  • The image isn't lazy loaded.
  • Only one size is loaded regardless of viewport

To reproduce

Steps to reproduce the behavior:

  1. Add a Products (Beta) block to a page.
  2. Save and check the page on the front end.
  3. See <img> element doesn't have loading, srcset, size attribute.
@dinhtungdu dinhtungdu added type: bug The issue/PR concerns a confirmed bug. block-type: product-query Issues related to/affecting all product-query variations. labels Jun 23, 2023
@dinhtungdu dinhtungdu self-assigned this Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
block-type: product-query Issues related to/affecting all product-query variations. type: bug The issue/PR concerns a confirmed bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant