Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A failed step should change the top level status of a run #1893

Closed
5 tasks done
pat-s opened this issue Jun 28, 2023 · 1 comment
Closed
5 tasks done

A failed step should change the top level status of a run #1893

pat-s opened this issue Jun 28, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@pat-s
Copy link
Contributor

pat-s commented Jun 28, 2023

Component

web-ui

Describe the bug

Currently when running (matrix) builds, when a step fails, the respective step is shown as "failed" but not the specific matrix pipeline.
I.e. in the following screenshot, "build images" is marked as "passed" while in fact it should be marked as "failed" if one step failed.

image

This is especially misleading when the run is collapsed, as it's indicates a successful run and the failure is only visible after expanding the run:

image

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-3033abc3"}

Additional context

related to #1871

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@pat-s pat-s added the bug Something isn't working label Jun 28, 2023
@6543
Copy link
Member

6543 commented Jan 9, 2024

should be fixed now :)

@6543 6543 closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants