Unexpected non-stable version for docker image woodpeckerci/woodpecker-server

[patrickuhlmann]

Component

server

Describe the bug

I used auto update with the docker image "woodpeckerci/woodpecker-server:latest". A few days ago I got the Woodpecker 3.0.0.rc Version. I would have expected that under this tag there will be only stable versions. There is a tag next where I would expect the development version.

Steps to reproduce

1. Pull and start the woodpeckerci/woodpecker-server:latest image

Expected behavior

I would not expect to get a RC version under the latest tag. The RC version might belong under the next tag.

System Info

N/A

Additional context

No response

Validations

• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[pat-s]

latest was pushed 8h ago during the 2.8.2 release

It might be that before that, latest was on 3.0.0.rc.0 due to the RC release of 3.0? Might need to check that.

Besides that being an unwanted happening, I recommend using semver tags as once the image is pulled and DB migrations applied, you can't go back.

I would even argue we should drop latest at all to avoid such issues in the future.

[rmi1974]

I would even argue we should drop latest at all to avoid such issues in the future.

Indeed. If "latest" is used it should never move backwards to an older release series.
With the backwards move of "latest" (2.8.2 as of this writing), woodpecker container now fails with obscure errors that most end users won't be able to resolve:

woodpecker-server  | 2024-12-20T18:47:43.615388000Z {"level":"info","time":"2024-12-20T18:47:43Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/shared/logger/logger.go:102","message":"log level: debug"}
woodpecker-server  | 2024-12-20T18:47:43.615420000Z {"level":"debug","time":"2024-12-20T18:47:43Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/cmd/server/setup.go:64","message":"server has sqlite3 support"}
woodpecker-server  | 2024-12-20T18:47:43.616553000Z {"level":"error","time":"2024-12-20T18:47:43Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/server/store/datastore/migration/001_legacy_to_xorm.go:82","message":"migration step 'create-table-users' missing, please upgrade to last stable v0.14.x version first"}
woodpecker-server  | 2024-12-20T18:47:43.616636000Z {"level":"error","error":"can't setup store: could not migrate datastore: migration xorm failed: legacy migration step missing","time":"2024-12-20T18:47:43Z","caller":"/woodpecker/src/github.com/woodpecker-ci/woodpecker/cmd/server/main.go:52","message":"error running server"}

I had to pin it to 3.0.0-rc2 now because I didn't want to restore to some older backup where the database is still old 2.8.x scheme.
Which forces me to fix up all the build plans due to breaking changes in 3.0.0 ... I guess sooner or later it had to be done anyway.

[patrickuhlmann]

What about using a stable tag? That refers to the last stable version?

[pat-s]

Personally I am against a rolling tag which crosses major versions automatically.
We had this discussion before, I think it got stuck somewhere.

I'd prefer having rolling tags for the respective major versions (and maybe minor). However, auto_tag doesn't work reliably in the buildx plugin which is also part of the reason this doesn't exist yet.

However, we can also create the tags manually in a previous step, I'll propose a PR for this soon.

[pat-s]

@anbraten Why reopen without a comment?

With #4600 this wont' happen anymore and the current latest is already again on 2.8.2.

[ki9us]

docker-compose.example.yaml now has :v3 but this throws:

[+] Pulling 2/2
 ✘ woodpecker-server Error context canceled                                                                                0.4s 
 ✘ woodpecker-agent Error  manifest for woodpeckerci/woodpecker-agent:v3 not found: manifest un...                         0.4s 
Error response from daemon: manifest for woodpeckerci/woodpecker-agent:v3 not found: manifest unknown: manifest unknown

:v2 is similar

[+] Pulling 2/2
 ✘ woodpecker-server Error manifest for woodpeckerci/woodpecker-server:v2 not found: manifest ...                          0.4s 
 ✘ woodpecker-agent Error  context canceled                                                                                0.4s 
Error response from daemon: manifest for woodpeckerci/woodpecker-server:v2 not found: manifest unknown: manifest unknown

The docs still say to use :latest.

Does anyone know what tags are needed to fix a gRPC version mismatch error?

[pat-s]

v3 and v2 do not exist (yet) as we just merged a PR that would create these for future release. And you're looking at the unreleased doc version of next.

Does anyone know what tags are needed to fix a gRPC version mismatch error?

Use a full semver tag (e.g. v2.8.2) or next, depending on what you're running on.