From 6ff71562d9570cac86a176d1407251d44da0b8b8 Mon Sep 17 00:00:00 2001 From: s3lph <5564491+s3lph@users.noreply.github.com> Date: Sun, 10 Sep 2023 19:59:07 +0200 Subject: [PATCH] fix: change config.config_data column type to longblob in mysql --- server/model/config.go | 2 +- .../migration/024_config_data_type.go | 37 +++++++++++++++++++ server/store/datastore/migration/migration.go | 1 + 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 server/store/datastore/migration/024_config_data_type.go diff --git a/server/model/config.go b/server/model/config.go index c84c0f9340..e28c26f1cc 100644 --- a/server/model/config.go +++ b/server/model/config.go @@ -30,7 +30,7 @@ type Config struct { RepoID int64 `json:"-" xorm:"UNIQUE(s) 'config_repo_id'"` Hash string `json:"hash" xorm:"UNIQUE(s) 'config_hash'"` Name string `json:"name" xorm:"config_name"` - Data []byte `json:"data" xorm:"config_data"` + Data []byte `json:"data" xorm:"LONGBLOB 'config_data'"` } // @name Config // PipelineConfig is the n:n relation between Pipeline and Config diff --git a/server/store/datastore/migration/024_config_data_type.go b/server/store/datastore/migration/024_config_data_type.go new file mode 100644 index 0000000000..a0fcfa91da --- /dev/null +++ b/server/store/datastore/migration/024_config_data_type.go @@ -0,0 +1,37 @@ +// Copyright 2023 Woodpecker Authors +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package migration + +import ( + "xorm.io/xorm" + "xorm.io/xorm/schemas" +) + +var alterTableConfigUpdateColumnConfigDataType = task{ + name: "alter-table-config-update-type-of-config-data", + fn: func(sess *xorm.Session) (err error) { + dialect := sess.Engine().Dialect().URI().DBType + + switch dialect { + case schemas.MYSQL: + _, err = sess.Exec("ALTER TABLE config MODIFY COLUMN config_data LONGBLOB") + default: + // xorm uses the same type for all blob sizes in sqlite and postgres + return nil + } + + return err + }, +} diff --git a/server/store/datastore/migration/migration.go b/server/store/datastore/migration/migration.go index 55a058d584..72e1335428 100644 --- a/server/store/datastore/migration/migration.go +++ b/server/store/datastore/migration/migration.go @@ -56,6 +56,7 @@ var migrationTasks = []*task{ &addOrgs, &addOrgID, &alterTableTasksUpdateColumnTaskDataType, + &alterTableConfigUpdateColumnConfigDataType, } var allBeans = []interface{}{