Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serde #74

Closed
wants to merge 4 commits into from
Closed

Fix serde #74

wants to merge 4 commits into from

Conversation

sshwy
Copy link

@sshwy sshwy commented Jul 11, 2023

This pr is trying to fix #72.

@wooorm
Copy link
Owner

wooorm commented Jul 11, 2023

Can you add a a test that breaks before your change, and works now? Thanks.

@sshwy
Copy link
Author

sshwy commented Jul 11, 2023

Can you add a a test that breaks before your change, and works now? Thanks.

I've added a simple test for it. I know it is not sufficient to prove that the result of serialization is consisitent with mdast's type definition. However I'm getting a little busy these days, so it may take a long time for me to write a more thorough test if you urge :).

Copy link
Owner

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small nits

Cargo.toml Outdated Show resolved Hide resolved
tests/mdast_serde.rs Show resolved Hide resolved
@wooorm
Copy link
Owner

wooorm commented Jul 12, 2023

Tests fail, I think this is because you’re now testing serde, but it’s an optional dependency, and should be a required dev-dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MDAST: serde Serialization/Deserialization not working
2 participants