Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline format is not preserved on new line #953

Open
kulkarni46 opened this issue Feb 1, 2022 · 3 comments
Open

Inline format is not preserved on new line #953

kulkarni46 opened this issue Feb 1, 2022 · 3 comments

Comments

@kulkarni46
Copy link

Expected

Inline format should be preserved on new line like in other standard editors

Observed

Inline format gets removed on new line

Reproduced

  1. Select Bold and type something
  2. Enter a new line
  3. Type new text. Bold format gets removed

Tested

[One Plus 7 Pro] on [11] with [1.5.3]

Seems like existing behaviour for library.
I have made a fix by making local changes to the library under applyInlineStyle in InlineFormatter.kt by moving the start position to first character before '\n' and checking its span.
Also dropped newline check under handleInlineStyling() in InlineFormatter.kt

Please let me know if this logic needs to be submitted as a Pull Request to the Editor

@hypest
Copy link
Contributor

hypest commented Feb 2, 2022

Please let me know if this logic needs to be submitted as a Pull Request to the Editor

Thanks for ticket @kulkarni46 and sure, feel free to open a PR! That said, not many folks are focused on Aztec at the moment so, it might take a bit of time for the review to go through.

@AashitaAndroid
Copy link

AashitaAndroid commented Aug 26, 2024

Would you please share the logic? @kulkarni46

@IslamRustam
Copy link

Would also love to see this added in a new version. For now I can only image a hacky way to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants