Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor media uploads: Provide feedback when photo access is disabled and camera is used #17468

Closed
twstokes opened this issue Nov 12, 2021 · 2 comments

Comments

@twstokes
Copy link
Contributor

twstokes commented Nov 12, 2021

Expected behavior

A message is shown to the user that access to photos is disabled.

Actual behavior

No message or feedback is shown to remind the user that access to photos is disabled.

Steps to reproduce the behavior

  1. Clean install WordPress (delete first, then install)
  2. Confirm that Settings -> WordPress -> "Allow WordPress to Access" -> Doesn't contain anything about photos
  3. In a new Post, tap the + and choose the Image block
  4. Select "Take a Photo"
  5. When prompted with "'WordPress' Would Like to Access Your Photos", tap "Don't Allow"
  6. When prompted with "'WordPress' Would Like to Access the Camera", tap "OK"
  7. Take a picture and choose "Use Photo"
  8. Tap "Don't Allow" on the "'WordPress' Would Like to Add to your Photos" prompt
  9. Observe that no message or feedback is shown to the user that the app doesn't have access to photos
  10. Confirm that Settings -> WordPress -> "Allow WordPress to Access" -> Photos -> "None"
  11. In the same Post, tap the + and choose the Image block
  12. Select "Take a Photo" (no access prompts should appear)
  13. Take a picture and choose "Use Photo" (no access prompts should appear)
  14. Observe that no message or feedback is shown to the user that the app doesn't have access to photos
Tested on iPhone 12, iOS 14.8, WPiOS 18.5.1
@twstokes twstokes changed the title Media uploads: Provide feedback to user when photo access is disabled Media uploads in the editor: Provide feedback to user when photo access is disabled and camera is used Nov 12, 2021
@twstokes twstokes changed the title Media uploads in the editor: Provide feedback to user when photo access is disabled and camera is used Editor media uploads: Provide feedback when photo access is disabled and camera is used Nov 12, 2021
@bluefuton
Copy link
Contributor

I ran into this one last night and it was pretty puzzling to figure out. The photos pane just pops up completely empty with no feedback about why that might be.

This is how Facebook Messenger handles the same situation, which would be a good pattern to follow:

Screen Shot 2022-05-18 at 11 39 18

@kean
Copy link
Contributor

kean commented Aug 25, 2023

Fixed by #21398. The access is not longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants