From a7f01a06d685092cd5242d16fc23cdc7d7da55bb Mon Sep 17 00:00:00 2001 From: Stefanos Togkoulidis Date: Fri, 8 Nov 2019 16:42:33 +0200 Subject: [PATCH 1/2] Update PR template to match main WP apps --- .github/PULL_REQUEST_TEMPLATE.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index aad1d9f6af..5225ac5ef6 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,8 @@ Fixes # To test: -Update release notes: +PR submission checklist: -- [ ] If there are user facing changes, I have added an item to `RELEASE-NOTES.txt`. +- [ ] I have considered adding unit tests where possible. + +- [ ] I have considered if this change warrants user-facing release notes and have added them to `RELEASE-NOTES.txt` if necessary. From 0f52666a2a67b836f1428dd771b31cbdd8a9054c Mon Sep 17 00:00:00 2001 From: Stefanos Togoulidis Date: Fri, 13 Dec 2019 14:28:10 +0200 Subject: [PATCH 2/2] Remove empty line between checkboxes --- .github/PULL_REQUEST_TEMPLATE.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5225ac5ef6..105a199b83 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -5,5 +5,4 @@ To test: PR submission checklist: - [ ] I have considered adding unit tests where possible. - - [ ] I have considered if this change warrants user-facing release notes and have added them to `RELEASE-NOTES.txt` if necessary.