-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's too easy to accidentally delete blocks #1146
Comments
With undo/redo available and in a prominent place, I'd assume that accidental deletion can be annoying but not a substantial problem. For the same reason, adding more steps to the deletion flow feels too cautious. I don't think we have usage data in place but I'd be inclined to close this ticket as "wontfix" and re-open if we get more user data. WDYT @iamthomasbishop ? |
@hypest Probably right. Either of the first 2 solutions would be preferred, and perhaps even both of them should be considered. |
@akirk ran into this exact issue, but for him it was the result of trying to fix a typo that was near the trash can icon. p1588188544116500-slack-mobile-gutenberg |
@mchowning We're considering changing the |
I think we can close that issue since remove option is reachable via ellipsis button in toolbar. |
Problem
Currently, it's too easy to accidentally delete blocks on the canvas, mainly because the
delete
(trash) icon on the inline toolbar is often docked right next to thehide keyboard
button.Note: this is especially a problem on iOS because our "scroll-to" positioning is "smarter" than Android. Most often when a block is focused (unless it's a tall block), it gets nicely docked above the Quick Toolbar.
Potential Fixes
A few approaches we could take:
Implement the
•••
menu in place of theremove block
icon (which we were eventually going to) and place theremove block
option in the subsequent sheet.Force the scroll position to about ~24px higher to limit accidental taps. This would leave some whitespace between the two toolbars.
Add a confirmation dialog that shows when removing a block from the canvas.
Data
To inform the approach we take, it would be useful to see some data on how often the
remove block
button is used.The text was updated successfully, but these errors were encountered: