Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt: Refactoring of the magic number used in the calculation of extraScrollHeight #1276

Closed
pinarol opened this issue Aug 8, 2019 · 0 comments · Fixed by #1939
Closed

Tech debt: Refactoring of the magic number used in the calculation of extraScrollHeight #1276

pinarol opened this issue Aug 8, 2019 · 0 comments · Fixed by #1939
Assignees
@etoledom
Labels
[Type] Technical Debt

Comments

@pinarol
Copy link
Contributor

pinarol commented Aug 8, 2019 •
edited
Loading

In this line there's a "+ 10" in the calculation of extraScrollHeight. Let's analyze what this refers to and try to replace it with a real style value, if this is not applicable let's try to give it a name to make it more clear.

First introduced in PR WordPress/gutenberg#16677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etoledom etoledom

Labels
[Type] Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[iOS] Fix autoscroll behaviour. wordpress-mobile/gutenberg-mobile
3 participants
@Tug @pinarol @etoledom