Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper component #1562

Closed
pinarol opened this issue Nov 8, 2019 · 5 comments · Fixed by #1640
Closed

Stepper component #1562

pinarol opened this issue Nov 8, 2019 · 5 comments · Fixed by #1640
Assignees
Labels
[Status] Needs Design [Type] Enhancement Improves a current area of the editor

Comments

@pinarol
Copy link
Contributor

pinarol commented Nov 8, 2019

We need a Stepper component to represent controls that has ≤ 6 or 8 options. At the moment, we'll use this to manage columns setting on Gallery and Columns blocks replacing the Slider there.

Describe the solution you'd like

Stepper should look different on both platforms:

@iamthomasbishop Could you provide designs with size, color, etc info as well as the dark mode version?

66678029-95f5a580-ec30-11e9-9256-0bcb69c2cd6f-1

Additional context

We had a discussion about using the native Stepper on iOS but then we agreed on implementing this fully on RN side since we are only planning to use this for controls that has ≤ 6 or 8 options currently.

@pinarol pinarol added [Type] Enhancement Improves a current area of the editor [Status] Needs Design labels Nov 8, 2019
@pinarol
Copy link
Contributor Author

pinarol commented Nov 20, 2019

@lukewalczak could you share the callstack library that provides the Stepper component? We can use it if it fits our needs or get inspiration from it.

@lukewalczak
Copy link
Contributor

Sure! I would suggest looking at the Stepper logic, especially in the context of "autorepeating" behaviour.

@geriux
Copy link
Contributor

geriux commented Nov 20, 2019

Hey @iamthomasbishop 👋 could you please share design specs for this component? Colors, Dark mode styles, etc.

Thanks!

@lukewalczak
Copy link
Contributor

Hey @geriux! You can find a design details on Zeplin

@geriux
Copy link
Contributor

geriux commented Nov 20, 2019

Hey @geriux! You can find a design details on Zeplin

Awesome, thank you!!

@geriux geriux mentioned this issue Dec 2, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Design [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants