Media & Text block - can't take a photo or video

[malinajirka]

Describe the bug
I can't add a photo or video using Media & Text block.

To Reproduce
Steps to reproduce the behavior:

1. Create a post in WPAndroid
2. Add "Media & Text" block
3. Click on it
4. Choose "Take a photo or video"
5. Nothing happens

Expected behavior
The app opens a camera app I guess?

Screenshots

Smartphone (please complete the following information):

• Device: Pixel 3
• OS: Android X
• Version develop 6e59663f8c0eda962c8a6fa0a45212fbd17942b1

[hypest]

I can reproduce the issue on WPiOS as well.

[mkevins]

I've reproduced this on Pixel 3a - Android 10 - real device, on:

WordPress-Android:
develop: 6e59663f8c0eda962c8a6fa0a45212fbd17942b1
and also:
8088889a2992d75bed0a9ac7ef042b83b53b654a

Also in libs/gutenberg-mobile:
release/1.17: 3c5051ce425ca3cb83a2a947d94c3de8901742ad

It seems that the language "Take a Photo or Video" was introduced in this PR: WordPress/gutenberg#17145, but I couldn't find an underlying implementation which allows for capture of both image or video within a single intent. If such an intent exists, we can launch it for MediaType.MEDIA. Otherwise, it isn't exactly clear to me how to proceed.

We have launchCamera and launchVideoCamera methods for capturing photos and videos, respectively. These each prepare an intent in slightly different ways (within WPMediaUtils). The capture image intent customizes the file path with a "wp-" prefix, and the capture video intent launches the MediaStore provider intent directly (without extras). The capture photo code path also has some extra checks to make sure the destination directory exists for writing the output file.

I'm not aware of any MediaStore provider to capture either a photo or a video. It seems the intents that return with a result are mutually exclusive in that regard. https://developer.android.com/reference/android/provider/MediaStore

One solution may be to use the existing photo capture intent and change the language to reflect that. Something like this might work:

diff --git a/react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java b/react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
index 1965d5f..6238c7f 100644
--- a/react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
+++ b/react-native-gutenberg-bridge/android/src/main/java/org/wordpress/mobile/WPAndroidGlue/WPAndroidGlueCode.java
@@ -182,7 +182,7 @@ public class WPAndroidGlueCode {
             public void requestMediaPickerFromDeviceCamera(MediaUploadCallback mediaUploadCallback, MediaType mediaType) {
                 mMediaPickedByUserOnBlock = true;
                 mPendingMediaUploadCallback = mediaUploadCallback;
-                if (mediaType == MediaType.IMAGE) {
+                if (mediaType == MediaType.IMAGE || mediaType == MediaType.MEDIA) {
                     mOnMediaLibraryButtonListener.onCapturePhotoButtonClicked();
                 } else if (mediaType == MediaType.VIDEO) {
                     mOnMediaLibraryButtonListener.onCaptureVideoButtonClicked();

Another solution could be to prepare an ACTION_CHOOSER intent, but that'd be one more additional tap in the user flow.

[pinarol]

I suggest doing this in 2 iterations:

• Temporary workaround: Let's quickly update the option as "Take a Photo" and make it work similar to Image block and ship it as soon as possible.

I think this is better than having a button doing nothing and it will give us time to address the whole thing.

• Implement Take a photo or video option on both platforms.

[hypest]

We could also try having separate options in the bottom sheet: "Take photo" and "Take video" which we should already have the native sides ready since those are the individual actions of the Image block and the Video block.

[pinarol]

That's even better, and it can be a long term solution! Thanks @hypest !

[hypest]

Closing since the option has been replaced by two separate ones with #1579.