Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on paste caused by Gutenberg #19097 #1688

Closed
hypest opened this issue Dec 17, 2019 · 1 comment
Closed

Crash on paste caused by Gutenberg #19097 #1688

hypest opened this issue Dec 17, 2019 · 1 comment
Labels
[Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web

Comments

@hypest
Copy link
Contributor

hypest commented Dec 17, 2019

Describe the bug
WordPress/gutenberg#19097 introduced a regression where pasting rich-text in a paragraph causes a crash with: Cannot read property 'textAlign' of undefined at https://github.com/WordPress/gutenberg/blob/662c38e45c99f4d9232791d409bbce64fce4a0de/packages/block-library/src/paragraph/transforms.js#L26

Assumes WordPress/gutenberg#19190 being already merged first.

To Reproduce
Steps to reproduce the behavior:

  1. Start with initial-html.js having only this:
<!-- wp:paragraph -->
<p><strong>Hello</strong> paste</p>
<!-- /wp:paragraph -->
  1. Run the demo app
  2. Go into the paragraph, select all text and "Copy" it
  3. Add a new paragraph block from the Inserter and focus it
  4. Long-tap and paste
  5. 💥
@hypest hypest added [Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web labels Dec 17, 2019
@hypest
Copy link
Contributor Author

hypest commented Jun 11, 2020

Fixed with WordPress/gutenberg#19196

@hypest hypest closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Crash [Type] Regression Existing functionality that got broken Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

No branches or pull requests

1 participant