Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display issue around videos on Android #1761

Closed
Tug opened this issue Jan 8, 2020 · 2 comments
Closed

Display issue around videos on Android #1761

Tug opened this issue Jan 8, 2020 · 2 comments
Labels
[Type] Bug Something isn't working [Type] Regression Existing functionality that got broken

Comments

@Tug
Copy link
Contributor

Tug commented Jan 8, 2020

Describe the bug

In Visual mode, vertical videos overlay their video block causing display issue, making the caption underneath hard to read and even overflowing to the toolbar and the next block.

We also lose the cover image that was previewing the video, for all type of videos.

Those are regressions for Android as they were not present in v1.19.

To Reproduce
Steps to reproduce the behavior:

  1. Add a video block
  2. Upload a vertical video
  3. Focus the video block
  4. See the display issue, still visible even after focusing another block

Expected behavior
I'd expect the video to not be displayed at all on focus

Screenshots
image

Smartphone (please complete the following information):

  • Device: Nokia 8
  • OS: Android 9
@Tug Tug added [Type] Bug Something isn't working [Type] Regression Existing functionality that got broken labels Jan 8, 2020
@Tug Tug changed the title Display issue around vertical videos on Android Display issue around videos on Android Jan 9, 2020
@hypest
Copy link
Contributor

hypest commented Jan 27, 2020

With the RN v0.61.5 upgrade now merged, can you test the issue again @Tug to see if by any chance it's back or not? Let's close the ticket if it's still not happening. Thanks!

@hypest
Copy link
Contributor

hypest commented Jun 11, 2020

Can't experience the issue with WPAndroid v15.0-rc-3 on a Pixel 2XL running Android 10. Closing but, we can reopen if the issue still happens for others.

@hypest hypest closed this as completed Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working [Type] Regression Existing functionality that got broken
Projects
None yet
Development

No branches or pull requests

2 participants