Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter UI #349

Closed
koke opened this issue Dec 11, 2018 · 3 comments
Closed

Inserter UI #349

koke opened this issue Dec 11, 2018 · 3 comments
Assignees
Milestone

Comments

@koke
Copy link
Member

koke commented Dec 11, 2018

A continuation of #58, the inserter works, but we still need it to match the designs.

image

It was originally estimated as 1 week of effort

@koke koke added this to the Beta milestone Dec 11, 2018
@koke koke mentioned this issue Dec 11, 2018
4 tasks
@koke
Copy link
Member Author

koke commented Dec 13, 2018

As reported by @rachelmcr, when we're replacing an existing empty block, the inserter placeholder is still visible saying "Add block here", when it shouldn't.

photo-12-12-2018-16-30-201

@koke
Copy link
Member Author

koke commented Dec 13, 2018

Design update from @iamthomasbishop:

screen shot 2018-12-11 at 3 56 49 pm

  • Block items need to be styled to match designs
  • Let’s remove the sheet header to simplify the design for the alpha and beta, then gauge whether it’s a usability concern via feedback. This essentially makes iOS and Android almost entirely aligned, primary difference is iOS uses SF Pro and Android uses Roboto for labels
  • Items should be aligned to the grid (see Zeplin for example), 16pt sheet margins left/right, 16pt left/right between items, 12pt bottom margin on each. iOS is a little tricky bc screen widths are odd numbers

@iamthomasbishop
Copy link
Contributor

A note: @etoledom is in the process of implementing RN bottom sheets, so hopefully this can utilize some of that progress: #535

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants