Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help view does not respect notch after rotation #4030

Closed
twstokes opened this issue Sep 24, 2021 · 0 comments · Fixed by #4110
Closed

Help view does not respect notch after rotation #4030

twstokes opened this issue Sep 24, 2021 · 0 comments · Fixed by #4110
Assignees
Labels
[OS] iOS [Type] Bug Something isn't working

Comments

@twstokes
Copy link
Contributor

Describe the bug
When the Help view (which is a full screen sheet) is rotated from portrait to landscape and back to portrait, its top does not return to its original location under the device's notch. Instead, the view's top equals the top of the device's screen.

To Reproduce
Steps to reproduce the behavior:

  1. In the portrait orientation, open the block editor in WPiOS by creating a new post.
  2. Tap the three dots at the top right.
  3. Tap "Help".
  4. Observe that the top of the view is under the notch.
  5. Rotate the device into landscape.
  6. Rotate the device back to portrait.
  7. Observe that the top of the view is at the top of the device's screen.
  8. Observe that the "Close" button at the top left may not be usable.

Expected behavior
The top of the view stays under the notch.

Screenshots
Screenshot showing before and after.

Smartphone (please complete the following information):

  • Device: iPhone 12
  • OS: iOS 14.5, iOS 15
  • Version 18.1

Additional context
This was also tested on an iPhone 8 (a notchless device) and it didn't seem to be affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[OS] iOS [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants