Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code block to support scroll to caret #469

Closed
pinarol opened this issue Jan 11, 2019 · 1 comment
Closed

Improve code block to support scroll to caret #469

pinarol opened this issue Jan 11, 2019 · 1 comment
Labels
[OS] iOS [Pri] Medium [Type] Enhancement Improves a current area of the editor
Milestone
Beta

Comments

@pinarol
Copy link
Contributor

pinarol commented Jan 11, 2019

We want code block to have scroll to caret abilities just like Paragraph and Heading blocks. Desired behavior can be seen in this PR. Currently Android supports this kind of behavior on system level so this is just necessary for iOS. We can make it possible by simply using RCTAztecView( see rich-text.js ) instead of react native's text input.
@pinarol pinarol added this to the Beta milestone Jan 11, 2019
@pinarol pinarol added the [Type] Enhancement Improves a current area of the editor label Jan 11, 2019
@koke koke mentioned this issue Apr 5, 2019
Open
@SergioEstevao SergioEstevao self-assigned this Mar 23, 2020
@SergioEstevao SergioEstevao mentioned this issue Mar 23, 2020
Closed
2 tasks
@SergioEstevao SergioEstevao changed the title iOS - Improve code block to support scroll to caret Improve code block to support scroll to caret May 4, 2020
@SergioEstevao SergioEstevao removed their assignment Jul 21, 2020
@SiobhyB
Copy link
Contributor

SiobhyB commented Jan 29, 2024

Closing as this is fixed now that the code block was refactored to use RichText. The block itself is still hidden behind a dev flag, but there is a separate GitHub issue related to enabling it.

@SiobhyB SiobhyB closed this as completed Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[OS] iOS [Pri] Medium [Type] Enhancement Improves a current area of the editor
Projects
Mobile Gutenberg
Status: Done (keep clean, manually)
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Issue/469 code block scroll to caret wordpress-mobile/gutenberg-mobile
3 participants
@SergioEstevao @SiobhyB @pinarol