Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up styling of starter paragraph block/placeholder #549

Closed
3 tasks
iamthomasbishop opened this issue Feb 6, 2019 · 1 comment
Closed
3 tasks

Clean up styling of starter paragraph block/placeholder #549

iamthomasbishop opened this issue Feb 6, 2019 · 1 comment
Assignees
Labels
[Type] Bug Something isn't working
Milestone

Comments

@iamthomasbishop
Copy link
Contributor

Initial "starter" block

This is in reference to the first block that appears when creating a new post – the one that has the label of "Start writing...".

image

Punch list

  • Change font-family to Noto Serif (it looks like it is currently the system default sans-serif)
  • Swap in (+) icon if possible – the unicode character feels out of place
  • Make sure placeholder text color is $gray aka #87a6bc
@iamthomasbishop iamthomasbishop added the [Type] Bug Something isn't working label Feb 6, 2019
@iamthomasbishop iamthomasbishop added this to the Beta milestone Feb 6, 2019
@iamthomasbishop iamthomasbishop self-assigned this Feb 6, 2019
@iamthomasbishop iamthomasbishop changed the title Clean up styling of starter paragraph block/placholder Clean up styling of starter paragraph block/placeholder Feb 6, 2019
@koke
Copy link
Member

koke commented Feb 14, 2019

I've tried swapping the unicode character with the icon and it works, with some limitations:

  • Since it's an inline image, it seems to be ignoring CSS, and I'm not sure if we can apply any styling to it
  • The paragraph placeholder uses RichText.placeholder, which I doubt will support the attributed strings right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants