Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine "Page Break" Block designs #618

Open
iamthomasbishop opened this issue Feb 19, 2019 · 2 comments
Open

Refine "Page Break" Block designs #618

iamthomasbishop opened this issue Feb 19, 2019 · 2 comments
Labels

Comments

@iamthomasbishop
Copy link
Contributor

Current

Currently, the Page Break Block looks like this:

img_1967

Proposal

Let's clean up the design a bit. It should look like this:

image

Specs

  • Text color: $gray aka #87a6bc
  • Font-family: Roboto on Android, SF Pro Text on iOS
  • Spacer around text-label: 16pt padding on each side (see example below) with white bg
  • Border color: $gray-lighten-20 aka #c8d7e1
  • Border width: 2pt
  • Border style: dashed
  • Border dash: 4pt
  • Border gap: 4pt

Spacer example
image

Notes

Note: this same design should also apply to the more block when we build it.

@iamthomasbishop iamthomasbishop self-assigned this Feb 19, 2019
@iamthomasbishop iamthomasbishop added the [Type] Enhancement Improves a current area of the editor label Feb 19, 2019
@iamthomasbishop iamthomasbishop added this to the Beta milestone Feb 19, 2019
@koke
Copy link
Member

koke commented Mar 25, 2019

If someone picks this up, there's a refactor in progress of nextpage: WordPress/gutenberg#14175

@koke
Copy link
Member

koke commented Apr 4, 2019

I prepared some quick improvements in WordPress/gutenberg#14826

A couple notes on the rest:

  • A dashed line is not currently supported with the library we're using. We can get it done in a different way, but it'll take more time. I'm also working on extracting a Separator component that works across platforms (Extract separator component out of nextpage block WordPress/gutenberg#14175), so I might be able to make some progress as part of that.
  • For the font, we're using $default-regular-font (serif on Android, Noto Serif on iOS). I think we'll eventually have to consolidate our custom variables with those from Gutenberg. I see _variables.scss using -apple-system, ..., Roboto, but it seems our SCSS processor chokes on that (maybe the -apple-system?)

I'm moving this to the Future column, since the remaining bits seem high effort for a small refinement, but let's keep the conversation going and see how to make progress in those two fronts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants