Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description/title to Image selection sheets #986

Closed
iamthomasbishop opened this issue May 16, 2019 · 3 comments · Fixed by WordPress/gutenberg#23083
Closed

Add description/title to Image selection sheets #986

iamthomasbishop opened this issue May 16, 2019 · 3 comments · Fixed by WordPress/gutenberg#23083
Assignees
Labels
HACK week HACK week June 2020 Media [Type] Enhancement Improves a current area of the editor

Comments

@iamthomasbishop
Copy link
Contributor

This won't be as big of an issue when we change the pencil (replace) icon eventually, but in the meantime, we should add some descriptive titles to the top of the bottom sheet, for some added clarity in the flow.

Replacing an Image:

image

For each platform, I'm hoping we can:

  • iOS: add as a top row description to the ActionSheet
  • Android: add it as a standard list item – text label color is $gray-darken-10 instead of $gray-dark

This could also apply to initial image selection:

image

@hypest
Copy link
Contributor

hypest commented May 27, 2019

Removing the milestone marker since we nowadays only add PRs to milestones.

@hypest hypest removed this from the v1.6 milestone May 27, 2019
@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label May 28, 2020
@SergioEstevao
Copy link
Contributor

@iamthomasbishop do you think the new icon for replacing image is enough? Or do you think we still need to add the extra information on the top of the action sheets?

@iamthomasbishop
Copy link
Contributor Author

We should probably have a description at the top of the sheet, as I don’t think the icon is always sufficiently clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HACK week HACK week June 2020 Media [Type] Enhancement Improves a current area of the editor
Projects
None yet
4 participants