-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventEmitter workshop #32
Comments
👍 |
@martinheidegger would you mind leaving some feedback on my first lessons?
Trying to make it as easy and understandable as possible :) The basic idea was to make Not sure if 'story-telling' approach is a good one, but I personally think it might be more enjoyable to follow something meaningful than just 'create event emitter that will listen to |
Need to sleep, will look at it tomorrow! |
Thanks! #timezone Have a good night then 👍 |
Okay, I read over this. I feel like it needs a lot of work. (sorry to say that but this might be a little harsh review, be sure that I like your effort a lot!):
|
Another thing: the workshop (imho) should cover event zalgo's :) |
Hey, thanks for your review. I appreciate your feedback as this is my first workshop ever! I do agree with your points, its kinda unclear sometimes what user should do. Would you think its worth sticking to the story as long as I fix those unclear parts and create some introduction or shall I just write plain JavaScript tasks? I am still a bit unsure whether that's the correct approach... Maybe I just should leave short story like introduction to each problem and describe task more technically in the goal section? Like - ok, it's cool I need to order pizzas but in goal there's actually written that I need to listen / emit few events on phone event emitter. I am going to put everything into introduction.md file and add some further explanations to each problem then. New version should be available by tomorrow :) |
My general suggestion is: "first make it work then make it fun" ... :) ... You can keep the story if you like. But only if the thing still works :) |
Cool, so I'll follow the general suggestion to make solutions first and then let's focus on proper problems descriptions. In terms of problems - do you think they cover enough of Event Emitter features? Thanks again for taking a look at it! I'll focus on better problems now, try to finish all of them and then will bump this topic again. |
A quick update -> I am going to resubmit a new, improved version this week, so stay tuned. |
Repo: https://github.com/grabbou/nodeschool-eventemitter
Not sure if this part has been already covered somewhere, but was thinking that we might want to create additional workshop to cover this field.
What you think?
Some simple topics that might be worth explaining during such a workshop:
em.tellMeWhenNewChickArrives
that will just callon
- event name hidden from end user [prototype chain is no longer a mystery!]emit
method, e.g.newChickArrived
use
method and create additional plugin, likeem.use(nightclub())
so night club emits new chick events - this might give valuable knowledge to attendees on how to split their huge app into reusable components, especially when aggregating some data (I have a working example so I can even feature it during the workshop)Languges to start with:
If anyone feels native in others, let me know and let's do it together!
The text was updated successfully, but these errors were encountered: