Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests related to Feature:Beacon script captures the right images on remote server #172

Closed
Mai-Saad opened this issue Nov 20, 2024 · 7 comments

Comments

@Mai-Saad
Copy link
Contributor

Mai-Saad commented Nov 20, 2024

Tests under Feature:Beacon script captures the right images are always failing on the remote server

=> cmd to run these tests is npm run test:lcp

=> for desktop:

  • seems no image on this page now "/lcp_bg_relative_attribute_incss/" ==> rocket-test-data review is needed => the style file which shall have BG images is not on the repo anymore /rocket-test-data/styles/lcp_styles.css"
    Image
@Mai-Saad
Copy link
Contributor Author

Mai-Saad commented Nov 21, 2024

For desktop: Adding the file lcp_styles to rocket-test-data and rerunning the test after pulling the latest test data update on the test environment and revisit json expectation if needed

@Mai-Saad
Copy link
Contributor Author

lcp desktop is now fixed, we just need to update test sites with latest rocket-test-data
Image

@Mai-Saad
Copy link
Contributor Author

Remain handling the mobile failures
Image

@Khadreal
Copy link
Contributor

Do we have the templates for those mobile in rocket-data updated ?

@Mai-Saad
Copy link
Contributor Author

Do we have the templates for those mobile in rocket-data updated ?

yes same pages are already passing for desktop

@Mai-Saad
Copy link
Contributor Author

Mai-Saad commented Nov 22, 2024

running only mobile lcp or both mobile &desktop is working fine on dev commit 2f39a0c
Image

Image

@Mai-Saad
Copy link
Contributor Author

Using commit 80bde4e working fine as well (remote dektop is minimized local)Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants