Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some compatibility having issue if root dir is set. #368

Closed
alimuzzaman opened this issue Mar 23, 2019 · 4 comments
Closed

Some compatibility having issue if root dir is set. #368

alimuzzaman opened this issue Mar 23, 2019 · 4 comments
Assignees
@antonkorotkov @alimuzzaman
Labels
type/bug type/compatibility
Milestone
v2.2.6

Comments

@alimuzzaman
Copy link
Contributor

https://wordpress.org/support/topic/css-not-working-through-siteorigin-css/

In some compatibility root dir isn't included in the returning URL.

We need to apply wp_stateless_bucket_link filter.
alimuzzaman pushed a commit that referenced this issue Mar 23, 2019
Firx for site origin.
99b37e7 
Issue #368
alimuzzaman pushed a commit that referenced this issue Mar 24, 2019
Fix for site origin css.
6948b03 
Issue #368
alimuzzaman pushed a commit that referenced this issue Mar 24, 2019
Fix for site origin CSS
23b02a9 
Issue #368
@antonkorotkov
Copy link
Contributor

@alimuzzaman do you need me to work on this? I see you do commits.

@alimuzzaman alimuzzaman added this to the v2.2.6 milestone Apr 4, 2019
@alimuzzaman
Copy link
Contributor Author

@antonkorotkov no.

alimuzzaman pushed a commit that referenced this issue Apr 8, 2019
Issue #368
a294525
@antonkorotkov
Copy link
Contributor

@alimuzzaman can you confirm the order of these lines is correct?

https://github.com/wpCloud/wp-stateless/blob/a294525d400aa276352e2aec61c897608610d01a/lib/classes/compatibility/gravity-forms.php#L67-L69

The $name is being redeclared in line 67 and 69 and used in between of them. That is correct and intentional?

@alimuzzaman
Copy link
Contributor Author

@antonkorotkov yes it's intentional. wp_stateless_file_name filter add root dir. Which should not be in local path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonkorotkov antonkorotkov

@alimuzzaman alimuzzaman

Labels
type/bug type/compatibility
Projects
None yet
Milestone
v2.2.6
Development

No branches or pull requests
3 participants
@antonkorotkov @ewsopp @alimuzzaman