Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API does not consider auto-clear routines disabled via filter #920

Open
raamdev opened this issue Dec 4, 2017 · 0 comments
Open

API does not consider auto-clear routines disabled via filter #920

raamdev opened this issue Dec 4, 2017 · 0 comments
Labels

Comments

@raamdev
Copy link
Contributor

raamdev commented Dec 4, 2017

If you disable the auto-clear routines like this:

add_filter('comet_cache_disable_auto_clear_cache_routines', '__return_true', 10, 0);

and then call the API like this:

comet_cache::clear();

the API does not clear the cache because this line assumes if the auto-clear routines are disabled then the cache should not be cleared.

The easiest way to fix this would be to update the calls in the API so that they pass true to signify that the routine was being called manually, which overrides the check if the auto-clear routines are disabled.

@raamdev raamdev added the bug label Dec 4, 2017
@raamdev raamdev added this to the Future Release milestone Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant