Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check !defined('WPINC') #454

Closed
jaswrks opened this issue Jan 23, 2015 · 2 comments
Closed

Check !defined('WPINC') #454

jaswrks opened this issue Jan 23, 2015 · 2 comments
Labels
compat. enhancement

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Jan 23, 2015

We should alter all of the s2Member PHP files so that they check for the more dependable WPINC constant, as opposed to $_SERVER['SCRIPT_FILENAME'] which is dependent upon the underlying server; i.e. not always available.
@jaswrks
Copy link
Contributor Author

jaswrks commented Jan 23, 2015

Next Release Changelog:

  • (s2Member/s2Member Pro) Security: This release of s2Member checks for the existence of the WordPress PHP Constant: WPINC instead of looking for the less reliable $_SERVER['SCRIPT_FILENAME']. Some site owners reported this was causing trouble in a localhost environment during testing, or when running s2Member on some hosts that are missing the SCRIPT_FILENAME environment variable; e.g. some Windows servers. Fixed in this release. See also: this GitHub issue if you'd like additional details.

@jaswrks jaswrks closed this as completed Jan 23, 2015
@jaswrks
Copy link
Contributor Author

jaswrks commented Feb 4, 2015

This issue was resolved in the release of s2Member v150203. Please see: http://www.s2member.com/kb/v150203/ If there are any follow-ups needed, please open a new issue and we will investigate. Thanks!

@wpsharks wpsharks locked and limited conversation to collaborators Feb 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
compat. enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaswrks