Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis not supported in REPL #25

Open
clsource opened this issue Mar 29, 2020 · 7 comments · May be fixed by #71
Open

Emojis not supported in REPL #25

clsource opened this issue Mar 29, 2020 · 7 comments · May be fixed by #71

Comments

@clsource
Copy link

System.print("📟")

will throw Unhandled key-code [dec]: 240

using MacOS Catalina
Wren 0.3.0

@joshgoebel
Copy link
Contributor

joshgoebel commented Apr 25, 2021

This is because all input is handled one byte at a time. Even if your remove the error you don't get an Emoji you just get two high ASCII characters... I wonder if the input loop shouldn't work with codePoints directly? #67 Otherwise it would have to include it's own UTF-8 handling logic...

@joshgoebel joshgoebel linked a pull request Apr 26, 2021 that will close this issue
@joshgoebel
Copy link
Contributor

@clsource Can you test? :-)

@joshgoebel
Copy link
Contributor

@ruby0x1 Can you confirm this is desirable (UTF-8 input) before I spend much more time on this... I presume it should be since we support UTF-8 natively... so it makes sense I think that this would "just work"... of course it'd only make sense inside strings, etc...

@clsource
Copy link
Author

Ok will do some testing :) is this the PR right? #71

@joshgoebel
Copy link
Contributor

Yes. :)

@joshgoebel
Copy link
Contributor

joshgoebel commented Aug 28, 2023

May I ask which PR completed this work? I see 71 is still open.

@clsource
Copy link
Author

Sorry my bad, I was just closing many issues to keep my pending list tidy.
Linking to the issue #71

@clsource clsource reopened this Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants