-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emojis not supported in REPL #25
Comments
This is because all input is handled one byte at a time. Even if your remove the error you don't get an Emoji you just get two high ASCII characters... I wonder if the input loop shouldn't work with codePoints directly? #67 Otherwise it would have to include it's own UTF-8 handling logic... |
@clsource Can you test? :-) |
@ruby0x1 Can you confirm this is desirable (UTF-8 input) before I spend much more time on this... I presume it should be since we support UTF-8 natively... so it makes sense I think that this would "just work"... of course it'd only make sense inside strings, etc... |
Ok will do some testing :) is this the PR right? #71 |
Yes. :) |
May I ask which PR completed this work? I see 71 is still open. |
Sorry my bad, I was just closing many issues to keep my pending list tidy. |
System.print("📟")
will throw
Unhandled key-code [dec]: 240
using MacOS Catalina
Wren 0.3.0
The text was updated successfully, but these errors were encountered: