Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning/Unpinning a Post to a Collection should replicate API's behaviour #8

Open
AngeloStavrow opened this issue Jun 30, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@AngeloStavrow
Copy link
Collaborator

Currently, WriteFreelyClient.pinPost(postId: at position: in collectionAlias: completion:) and WriteFreelyClient.unpinPost(postId: from collectionAlias: completion:) take a single post ID String.

That's not in line with how the WriteFreely API works — both /api/collections/{COLLECTION_ALIAS/pin and /api/collections/{COLLECTION_ALIAS/unpin take an array of objects ([{id: String, position: Int}] for the former, [{id: String}] for the latter).

The client should be fixed to handle bulk pinning and unpinning, just like the API. This issue is classified a bug because it diverges from the API's behaviour.

(It may be a good idea to get #7 in place first before working on this.)

@AngeloStavrow AngeloStavrow added the bug Something isn't working label Jun 30, 2020
@AngeloStavrow AngeloStavrow changed the title Pinning/Unpinning a Post to a Collection should take an array of Posts as argument. Pinning/Unpinning a Post to a Collection should replicate API's behaviour Jun 30, 2020
@AngeloStavrow AngeloStavrow added the hacktoberfest Eligible for Hacktoberfest 2023 label Sep 21, 2023
@AngeloStavrow AngeloStavrow removed the hacktoberfest Eligible for Hacktoberfest 2023 label Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant