Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the project build to be identical with MUI's build #290

Open
Tracked by #21415
brionmario opened this issue Oct 14, 2024 · 0 comments
Open
Tracked by #21415

Migrate the project build to be identical with MUI's build #290

brionmario opened this issue Oct 14, 2024 · 0 comments
Assignees
Labels
bug Something isn't working hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. package:primitives Issues/PRs related to the `@oxygen-ui/primitives` package. package:react Issues/PRs related to the `@oxygen-ui/react` package. package:react-icons Issues/PRs related to the `@oxygen-ui/react-icons` package.

Comments

@brionmario
Copy link
Member

Is your suggestion related to an experience ? Please describe.

Currently, we use a custom rollup build for generating the distributions.

While this works logically, there are several concerns associated with it:

Bundle size is way high.

  • mui - 6.36 MB

    Screenshot 2024-10-14 at 15 44 56
  • oxygen-ui - 32.6 MB

    Screenshot 2024-10-14 at 15 45 24

    ⭐️ esm & the cjs bundles generated by rollup seems to be the culprit.

    Screenshot 2024-10-14 at 15 48 06

API is different

Ex:

  • mui

    import { ThemeProvider } from '@mui/material/styles';
  • oxygen-ui

    import { ThemeProvider } from "@oxygen-ui/react/theme";

Some APIs are not exposed

Ex: SelectChangeEvent is not exported from the Select APIs.

Describe the improvement

Migrate the build to be identical with MUI.

Additional context

N/A

@brionmario brionmario added bug Something isn't working hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. labels Oct 14, 2024
@brionmario brionmario self-assigned this Oct 14, 2024
@brionmario brionmario added package:react Issues/PRs related to the `@oxygen-ui/react` package. package:primitives Issues/PRs related to the `@oxygen-ui/primitives` package. package:react-icons Issues/PRs related to the `@oxygen-ui/react-icons` package. labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Issues dedicated for the annual annual Hacktoberfest open source festival. package:primitives Issues/PRs related to the `@oxygen-ui/primitives` package. package:react Issues/PRs related to the `@oxygen-ui/react` package. package:react-icons Issues/PRs related to the `@oxygen-ui/react-icons` package.
Projects
None yet
Development

No branches or pull requests

1 participant