Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedreader module - Line breaks in titles #1088

Closed
ajh-sr opened this issue Jun 3, 2021 · 8 comments
Closed

feedreader module - Line breaks in titles #1088

ajh-sr opened this issue Jun 3, 2021 · 8 comments
Assignees
Labels
🐛 bug "Houston, we've had a problem."

Comments

@ajh-sr
Copy link

ajh-sr commented Jun 3, 2021

I'm not sure if this is a bug or if this is expected? Or if medium.com's feed is malformed?

What's broken?

image

The article: Top Contributors Impacting
Your Real-Time Application
Performance

@senorprogrammer
Copy link
Collaborator

Frankly, I'm surprised there are line breaks in a feed item title. That seems weird. But WTF should also handle that gracefully so I'm going to label this a bug and see about getting a fix for it.

@senorprogrammer senorprogrammer added the 🐛 bug "Houston, we've had a problem." label Jun 4, 2021
@GibranHL0
Copy link
Contributor

Hey 👋, I'm new to the project and I'd like to contribute.
Could you assign me this issue?

@senorprogrammer senorprogrammer assigned ajh-sr and GibranHL0 and unassigned ajh-sr Jun 29, 2021
@senorprogrammer
Copy link
Collaborator

Great! It's all yours.

@GibranHL0
Copy link
Contributor

Thanks, I'll comment proposal as soon as possible.

@ajh-sr
Copy link
Author

ajh-sr commented Jun 30, 2021

🙇 Thanks @GibranHL0

@senorprogrammer
Copy link
Collaborator

If you've got an idea for a fix, feel free to submit a PR. No need to propose, it's not that formal here :)

@GibranHL0
Copy link
Contributor

Opened a PR #1090

@senorprogrammer
Copy link
Collaborator

Fixed by #1090

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug "Houston, we've had a problem."
Development

No branches or pull requests

3 participants