Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude-elements notification displayed in the AET report (text and position) #372

Closed
radeklawgmin opened this issue Sep 26, 2018 · 0 comments · Fixed by #410
Closed

Exclude-elements notification displayed in the AET report (text and position) #372

radeklawgmin opened this issue Sep 26, 2018 · 0 comments · Fixed by #410
Assignees
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help. UX

Comments

@radeklawgmin
Copy link
Contributor

Version used

  • AET 3.0

Context of the issue/feature

In fact there are two issues to be fixed here:

  1. The place where the exclude-elements notification is displayed seems to be improper.
    Why don't we have it displayed below the settings bar on some background marked with red (let's discuss it)?
  2. The other issue is related to the text that is currently displayed which is:
    "Exclude info: Elements to exclude are not found on page".
    Why don't we change it to:
    "The following elements to be excluded have not been found on page:
  • {element-1 to be excluded}
  • {element-2 to be excluded}
    "

Steps to reproduce

  1. Open any report with the exclude-info feature applied
  2. Note where the exclude-notification is displayed
  3. Note the text displayed

Appendix

exclude-elements-text

@radeklawgmin radeklawgmin added enhancement help wanted Hey, contributor! We need your help. labels Sep 26, 2018
@malaskowski malaskowski added good first issue This is great opportunity to start your adventure with AET. UX Hacktoberfest labels Sep 27, 2018
@Jakub-Izbicki Jakub-Izbicki self-assigned this Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue This is great opportunity to start your adventure with AET. help wanted Hey, contributor! We need your help. UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants