Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme_icons support in WXT or @wxt-dev/auto-icons #1120

Open
kepi opened this issue Oct 28, 2024 · 1 comment
Open

theme_icons support in WXT or @wxt-dev/auto-icons #1120

kepi opened this issue Oct 28, 2024 · 1 comment

Comments

@kepi
Copy link
Contributor

kepi commented Oct 28, 2024

Feature Request

Firefox supports theme_icons field in browser_action (MV2) or action (MV3). It would be great to automatically discover (or generate with auto-icons) those.

It would be great to auto discover them i.e. in icon/16-light.png etc.

For auto-icons, IMHO best approach would be automatically check for icon/light.(png|svg) and icon/dark.(png|svg) and if present, generate proper sizes. Or little worse, activate it with with i.e. baseLightIconPath option.

What are the alternatives?

Simply define them manually via manifest.browser_action.theme_icons.

Additional context

documentation

@kepi kepi added the feature label Oct 28, 2024
@aklinker1
Copy link
Collaborator

I'm onboard adding this to WXT. Not a priority right now, would maybe get to this after v1.0 is released. Anyone else is free to contribute this though.

Here's some helpful links to get started:

@aklinker1 aklinker1 added this to the v1.1 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants