-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anti virus triggering. #1302
Comments
Woah, thanks for reporting, that's not good... Unfamiliar with these window defender alerts, and the Microsoft doc sucks, doesn't tell us anything. I don't have Windows, so could you do some testing for me?
|
|
additional note. I am trying to migrate my extension from plasmo to wxt, and I didn't have any anti virus issues with plasmo. edit: same virus issue with pnpm and npm |
I was able to replicate the virus on a new repo, I have published it under. https://github.com/SamHoque/wxt-virus-demo |
downloading the manifest file from this, also triggers my anti virus it has something to do with the generated manifest. |
Removing either the content, background or sidepanel fixes the bug, but having all 3 causing the bug, I am guessing microsoft is checking for a pattern, maybe the order in how the json is formatted with all 3 of these entry points set. |
my theory was correct, this is the same file, with just fields in a different order |
So is it a file hash they're checking? Does your manifest just happen to have the same MD5 or something as a known virus? |
I don't think its a file hash, since unminfied version also gets flagged, I am guessing its the json object order. |
however, I am rearranging it now, and still seem to be getting virus alerts, very weird. |
it has something to do with the generated manifest file, the virus defender doesn't like something in it. |
Fixed manifest.json Manifest detected on virus: the problem is the background service_worker I have attached both files for you to analyze as well, this is very stupid if this is the problem. |
locally updating the
I think in future, we should allow users to be able to configure each entrypoint name via the configuration for minification/custom naming or dirs. (Similar to vite chunks) |
Describe the bug
When running the build command, I am getting an anti virus alert on the manifest.json file.
Reproduction
run build
Steps to reproduce
No response
System Info
Used Package Manager
bun
Validations
The text was updated successfully, but these errors were encountered: