Disallow calling "helperMissing" and "blockHelperMissing" directly #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknapp
force-pushed
the
forbid-calling-missing-helper
branch
from
aad5ad8
to
7b67a29
Compare
nknapp
force-pushed
the
forbid-calling-missing-helper
branch
from
f6a6b71
to
c12c5a9
Compare
|
This PR essentially moves the That way, the helpers cannot be called directly anymore. |
|
I'll release this change now. Because I want to talk about the general issue at a user-group and I feel better if the current security issue is not working like this anymore. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1558