Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine why twentythirteen's scripts and styles aren't combining optimally #9

Closed
westonruter opened this issue Aug 2, 2013 · 2 comments
Closed

Determine why twentythirteen's scripts and styles aren't combining optimally #9

westonruter opened this issue Aug 2, 2013 · 2 comments
Labels
bug

Comments

@westonruter
Copy link
Contributor

dependency_minification__local_wordpress_dev__wordpress
@westonruter
Copy link
Contributor Author

I think it lies in the group detection. Instead of looking at the group extra, we can check for did_action('wp_footer') to determine if it is a footer script or not.

@westonruter westonruter mentioned this issue Aug 22, 2013
Closed
shadyvb added a commit to shadyvb/wp-dependency-minification that referenced this issue Aug 24, 2013
@shadyvb
Prevent default built-in scripts from breaking minification groups. x…
f0eb3bc 
…wp#9 xwp#22
@westonruter
Copy link
Contributor Author

Included in the 0.9.3 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@westonruter