Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all uses of extract() from Stream #556

Closed
frankiejarrett opened this issue May 30, 2014 · 0 comments · Fixed by #557
Closed

Remove all uses of extract() from Stream #556

frankiejarrett opened this issue May 30, 2014 · 0 comments · Fixed by #557
Labels
bug requirement

Comments

@frankiejarrett
Copy link
Contributor

As noted recently in Trac, the use of extract() in WordPress core is being removed.

To keep in line with core standards, we should remove all uses in Stream as well.

Furthermore, I encountered a bug with live updates on my local dev environment what was being caused by the use of extract() on self::$list_table->_pagination_args.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of extract() throughout Stream xwp/stream
1 participant
@frankiejarrett