Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add toggle and reload command. #13

Closed
LordYarkan opened this issue Apr 4, 2024 · 4 comments · Fixed by #14
Closed

[FEAT] Add toggle and reload command. #13

LordYarkan opened this issue Apr 4, 2024 · 4 comments · Fixed by #14

Comments

@LordYarkan
Copy link

Hi,

The DynamicLights plugin is great, could you add these commands?
1- /dynamiclight reload: to reload the configuration and avoid restarting the server.
2- /dynamiclight toggle: those who do not want dynamiclight

I await your response, thank you

@xCykrix
Copy link
Owner

xCykrix commented Apr 11, 2024

Hello @LordYarkan. I have added this to the roadmap to be included in (hopefully) the next release.

I will add the capability to reload lights.yml so the server does not require a restart to change what emits light and the light level, however, changes to config.yml WILL require a restart due to how events are registered and the culling is calculated.

@xCykrix xCykrix changed the title IMPROVEMENT IN FUNCTIONS [FEAT] Add toggle and reload command. Apr 15, 2024
@xCykrix xCykrix linked a pull request Apr 16, 2024 that will close this issue
13 tasks
@xCykrix
Copy link
Owner

xCykrix commented Apr 16, 2024

Added by #14. This adds the following functionality:

  • /dynamiclights reload (dynamiclights.reload) - Reloads changes to lights.yml
  • /dynamiclights toggle (dynamiclights.toggle) - Allows players to independently choose to render lighting for their client.

After full testing and validation, this will be scheduled for release in v1.0.6.

Moving to Blocked until release.

@xCykrix
Copy link
Owner

xCykrix commented Apr 16, 2024

Committed to main branch and scheduled for release.

@xCykrix
Copy link
Owner

xCykrix commented Apr 17, 2024

Landed in v1.0.6.

https://github.com/xCykrix/DynamicLights/releases/tag/v1.0.6
https://www.spigotmc.org/resources/dynamiclights.110707/update?update=541012

Please let me know if you have any issues or if something is not working as expected in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants