Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosening the restriction on index type #161

Open
asinghvi17 opened this issue Mar 15, 2023 · 1 comment
Open

Loosening the restriction on index type #161

asinghvi17 opened this issue Mar 15, 2023 · 1 comment

Comments

@asinghvi17
Copy link
Member

We should also open up the index type to Real values - this would allow people to load arbitrary results which have some time-like variable.

More generally, I don't think there is a reason that we shouldn't accept any type for which Base.lt(x::T, y::T) is defined (meaning it can be sorted). Julia is all about generality, and this would allow people to use e.g. Unitful.jl numbers as indices. Plus, all our algorithms should be generic enough not to be worried about the index type anyway.

@chiraganand
Copy link
Member

Separate similar discussions going on in #167 and #151.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants